[webkit-reviews] review granted: [Bug 129009] Add more new SPI methods : [Attachment 224564] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 18 16:28:10 PST 2014


Tim Horton <thorton at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 129009: Add more new SPI methods
https://bugs.webkit.org/show_bug.cgi?id=129009

Attachment 224564: Patch
https://bugs.webkit.org/attachment.cgi?id=224564&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224564&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:510
> +    return !applicationName ? nil : (NSString *)applicationName;

why not flip this? it reads better that way, imo. also, do you actually need
this explicit cast?


More information about the webkit-reviews mailing list