[webkit-reviews] review granted: [Bug 129000] [WebRTC] Updating RTCConfiguration to match WebRTC editor's draft of 01/27/2014 : [Attachment 224553] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 129000: [WebRTC] Updating RTCConfiguration to match WebRTC editor's draft
of 01/27/2014
https://bugs.webkit.org/show_bug.cgi?id=129000

Attachment 224553: Patch
https://bugs.webkit.org/attachment.cgi?id=224553&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224553&action=review


> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:77
> +    String iceTransports;
> +    String requestIdentity;

Nit: these can be declared just before they are used.

> Source/WebCore/platform/mediastream/RTCConfiguration.h:77
> +    const String& iceTransports() { return m_iceTransports; }

Nit: this method can be made const.

> Source/WebCore/platform/mediastream/RTCConfiguration.h:83
> +    const String& requestIdentity() { return m_requestIdentity; }

Ditto.