[webkit-reviews] review granted: [Bug 128534] 'mouseenter' mouse compat event not fired when listeners for touch events : [Attachment 224159] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 128534: 'mouseenter' mouse compat event not fired when listeners for touch
events
https://bugs.webkit.org/show_bug.cgi?id=128534

Attachment 224159: Patch
https://bugs.webkit.org/attachment.cgi?id=224159&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224159&action=review


r=me

> Source/WebCore/ChangeLog:8
> +	   The code dispatchign mouseenter and mouseleave events was making the
assumption that

dispatching

> Source/WebCore/ChangeLog:15
> +	   processing of mouse events. The update is done along the events
mouseover and mouseout.

along what?

> Source/WebCore/dom/Document.cpp:5873
> +    for (size_t i = 0; i < removeCount; ++i)

range for

> Source/WebCore/page/EventHandler.cpp:2384
> +	       RenderElement* oldHoverObj = m_lastElementUnderMouse ?
m_lastElementUnderMouse->renderer() : nullptr;
> +	       RenderElement* newHoverObj = m_elementUnderMouse ?
m_elementUnderMouse->renderer() : nullptr;

I'd call these *Renderer instead of *Obj.

> Source/WebCore/page/EventHandler.cpp:2387
> +	       Vector<RefPtr<Element>, 32> leftElementsChain;

This could be Vector<Ref<Element>> since it never contains null pointers.

> Source/WebCore/page/EventHandler.cpp:2400
> +	       Vector<RefPtr<Element>, 32> enteredElementsChain;

Ditto.

> Source/WebCore/page/EventHandler.cpp:2415
> +	       for (size_t i = 0; i < leftElementsChain.size(); ++i) {

range for

> Source/WebCore/page/EventHandler.cpp:2425
> +	       for (size_t i = 0, size = enteredElementsChain.size(); i < size;
++i) {

range for