[webkit-reviews] review granted: [Bug 128993] Merge notifyComponentsOnChangedSelection into respondToSelectionChange : [Attachment 224543] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 18 14:26:08 PST 2014


Andreas Kling <akling at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 128993: Merge notifyComponentsOnChangedSelection into
respondToSelectionChange
https://bugs.webkit.org/show_bug.cgi?id=128993

Attachment 224543: Patch
https://bugs.webkit.org/attachment.cgi?id=224543&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224543&action=review


Seems reasonable. r=me

> Source/WebCore/editing/Editor.cpp:3300
> +    // FIXME: Merge this to open source
https://bugs.webkit.org/show_bug.cgi?id=38830

Is this comment actually relevant? We are *in* open source :)


More information about the webkit-reviews mailing list