[webkit-reviews] review granted: [Bug 128949] setSelectionRange should set selection without validation : [Attachment 224528] Fix ML for the last time

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 128949: setSelectionRange should set selection without validation
https://bugs.webkit.org/show_bug.cgi?id=128949

Attachment 224528: Fix ML for the last time
https://bugs.webkit.org/attachment.cgi?id=224528&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224528&action=review


Looks ok to me.

> Source/WebCore/dom/Position.h:-279
> -    return Position(Position::findParent(node), node->nodeIndex(),
Position::PositionIsOffsetInAnchor);

Should you ASSERT node->parentNode() here too?