[webkit-reviews] review granted: [Bug 128938] [iOS] All WebKit clients should encrypt WebCrypto keys automatically : [Attachment 224443] added fallback to _NSGetProgname

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 128938: [iOS] All WebKit clients should encrypt WebCrypto keys
automatically
https://bugs.webkit.org/show_bug.cgi?id=128938

Attachment 224443: added fallback to _NSGetProgname
https://bugs.webkit.org/attachment.cgi?id=224443&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224443&action=review


> Source/WebCore/crypto/mac/SerializedCryptoKeyWrapMac.mm:78
> +    NSString *applicationName = [[NSBundle mainBundle]
objectForInfoDictionaryKey:@"CFBundleDisplayName"];

Shouldn’t we try to get this from -localizedInfoDictionary first?

Let’s use a local variable for [NSBundle mainBundle].