[webkit-reviews] review granted: [Bug 128504] Web Inspector: AX: more properties: exists, required, and invalid (exists was previously combined with ignored) : [Attachment 224453] patch with review feedback

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted James Craig
<jcraig at apple.com>'s request for review:
Bug 128504: Web Inspector: AX: more properties: exists, required, and invalid
(exists was previously combined with ignored)
https://bugs.webkit.org/show_bug.cgi?id=128504

Attachment 224453: patch with review feedback
https://bugs.webkit.org/attachment.cgi?id=224453&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224453&action=review


> Source/WebCore/inspector/InspectorDOMAgent.cpp:1443
>	   .setNodeId(pushNodePathToFrontend(node));
> -
> +    if (exists) {

An empty line here helps readability.

> Source/WebInspectorUI/UserInterface/DOMNodeDetailsSidebarPanel.js:291
> +		   ];
>		   this._accessibilityEmptyRow.hideEmptyMessage();

An empty line here would be nice.