[webkit-reviews] review granted: [Bug 128956] [Cocoa] Implement -description in some API objects : [Attachment 224475] Implement -description in UIProcess/API/Cocoa and Shared/API/Cocoa

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted mitz at webkit.org
<mitz at webkit.org>'s request for review:
Bug 128956: [Cocoa] Implement -description in some API objects
https://bugs.webkit.org/show_bug.cgi?id=128956

Attachment 224475: Implement -description in UIProcess/API/Cocoa and
Shared/API/Cocoa
https://bugs.webkit.org/attachment.cgi?id=224475&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224475&action=review


> Source/WebKit2/Shared/API/Cocoa/WKRemoteObjectInterface.mm:146
> +    return [NSString stringWithFormat:@"<%@: %p; protocol = \"%@\";
identifier = \"%@\">", NSStringFromClass([self class]), self, _identifier,
NSStringFromProtocol(_protocol)];

Please use self.class instead of [self class].

> Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfo.mm:53
> +    return [NSString stringWithFormat:@"<%@: %p; isMainFrame = %d; request =
%@>", NSStringFromClass([self class]), self, _mainFrame, _request.get()];

Please use self.class instead of [self class]. I think you should return either
YES or NO for the main frame bit.

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationAction.mm:41
> +    return [NSString stringWithFormat:@"<%@: %p; navigationType = %ld;
request = %@; sourceFrame = %@; destinationFrame = %@>",
NSStringFromClass([self class]), self,

Please use self.class instead of [self class].

> Source/WebKit2/UIProcess/API/Cocoa/WKNavigationResponse.mm:40
> +    return [NSString stringWithFormat:@"<%@: %p; frame = %@; response =
%@>", NSStringFromClass([self class]), self, _frame.get(), _response.get()];

Please use self.class instead of [self class].

> Source/WebKit2/UIProcess/API/Cocoa/WKProcessClass.mm:83
> +    return [NSString stringWithFormat:@"<%@: %p; configuration = %@>",
NSStringFromClass([self class]), self, _configuration.get()];

Please use self.class instead of [self class].

> Source/WebKit2/UIProcess/API/Cocoa/WKProcessClassConfiguration.mm:49
> +    NSString *description = [NSString stringWithFormat:@"<%@: %p;
maximumProcessCount = %ld", NSStringFromClass([self class]), self,
_maximumProcessCount];

Please use self.class instead of [self class].

> Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:42
> +    return [NSString stringWithFormat:@"<%@: %p; processClass = %@;
preferences = %@>", NSStringFromClass([self class]), self, _processClass.get(),
_preferences.get()];

Please use self.class instead of [self class].