[webkit-reviews] review granted: [Bug 128982] Convert position:sticky to position:static upon copy and paste : [Attachment 224524] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 128982: Convert position:sticky to position:static upon copy and paste
https://bugs.webkit.org/show_bug.cgi?id=128982

Attachment 224524: Patch
https://bugs.webkit.org/attachment.cgi?id=224524&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224524&action=review


> Source/WebCore/editing/EditingStyle.cpp:1231
>      RefPtr<CSSPrimitiveValue> fixed =
cssValuePool().createIdentifierValue(CSSValueFixed);
> +    RefPtr<CSSPrimitiveValue> absolute =
cssValuePool().createIdentifierValue(CSSValueAbsolute);

You should declare these before first use, to avoid making them in the early
return cases.