[webkit-reviews] review granted: [Bug 128964] Move IndexedDB module, LevelDB code to std::unique_ptr : [Attachment 224488] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 18 10:35:22 PST 2014


Andreas Kling <akling at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 128964: Move IndexedDB module, LevelDB code to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=128964

Attachment 224488: Patch
https://bugs.webkit.org/attachment.cgi?id=224488&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224488&action=review


r=me

> Source/WebCore/Modules/indexeddb/IDBPendingDeleteCall.h:38
> +    IDBPendingDeleteCall(PassRefPtr<IDBCallbacks> callbacks)

explicit

> Source/WebCore/platform/leveldb/LevelDBDatabase.cpp:266
> +    IteratorImpl(std::unique_ptr<leveldb::Iterator>);

explicit

> Source/WebCore/platform/leveldb/LevelDBTransaction.h:102
> +	   TreeIterator(LevelDBTransaction*);

explicit

> Source/WebCore/platform/leveldb/LevelDBTransaction.h:124
> +	   TransactionIterator(PassRefPtr<LevelDBTransaction>);

explicit

> Source/WebCore/platform/leveldb/LevelDBTransaction.h:174
> +    LevelDBWriteOnlyTransaction(LevelDBDatabase*);

explicit


More information about the webkit-reviews mailing list