[webkit-reviews] review denied: [Bug 128693] [CSS Shapes] Adjust lineTop position to the next available wrapping location at shape-outsides : [Attachment 224048] update patch after r164006

[bugzilla-daemon at webkit.org]

Bem Jones-Bey <bjonesbe at adobe.com> has denied Zoltan Horvath
<zoltan at webkit.org>'s request for review:
Bug 128693: [CSS Shapes] Adjust lineTop position to the next available wrapping
location at shape-outsides
https://bugs.webkit.org/show_bug.cgi?id=128693

Attachment 224048: update patch after r164006
https://bugs.webkit.org/attachment.cgi?id=224048&action=review

------- Additional Comments from Bem Jones-Bey <bjonesbe at adobe.com>
I don't think this is the correct approach. It doesn't work for stacked floats,
and is going to be very hard at bast to make it work in cases where you have
floats on either side of the container. I think the first solution should be to
simply change the line layout code to not jump to the bottom of the float if it
has shape-outside and just walk down the float. This way, stacked floats, etc
will all work. Then we should attack trying to make it position in a more
optimal manner.