[webkit-reviews] review granted: [Bug 128418] [GTK] geneate-gtkdoc should use argparse : [Attachment 224457] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 128418: [GTK] geneate-gtkdoc should use argparse
https://bugs.webkit.org/show_bug.cgi?id=128418

Attachment 224457: Patch
https://bugs.webkit.org/attachment.cgi?id=224457&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224457&action=review


> Tools/gtk/generate-gtkdoc:170
> -    options = get_common_options().copy()
> -    options.update({
> +    options = {
> +	   'decorator':
'WEBKIT_API|WEBKIT_DEPRECATED|WEBKIT_DEPRECATED_FOR\(.+\)',
> +	   'deprecation_guard': 'WEBKIT_DISABLE_DEPRECATED',
> +	   'library_path' : common.library_build_path(),
> +	   'virtual_root' : virtual_root,

Why are we now duplicating this code in every get_*_options method?