[webkit-reviews] review denied: [Bug 128929] border-box clip-paths jump around when outline changes : [Attachment 224418] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 17 23:06:28 PST 2014


Dirk Schulze <krit at webkit.org> has denied Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 128929: border-box clip-paths jump around when outline changes
https://bugs.webkit.org/show_bug.cgi?id=128929

Attachment 224418: Patch
https://bugs.webkit.org/attachment.cgi?id=224418&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224418&action=review


> LayoutTests/css3/masking/clip-path-root-relative-bounds-expected.html:8
> +	-webkit-clip-path: circle(50%, 50%, 50%) border-box;

Could you use the new syntax please? This is the deprecated syntax that I would
very much like to remove.

New syntax is circle(<radius> at <position>) and to archive the same as you
did, just circle() :)

Anyway. Still don't understand why rootRelativeBounds takes the offset of
outline but not the dimension.


More information about the webkit-reviews mailing list