[webkit-reviews] review denied: [Bug 128850] GetMyArgumentByVal in FTL : [Attachment 224439] Added GetMyArgumentByVal to FTL

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Matthew Mirman <mmirman at apple.com>'s
request for review:
Bug 128850: GetMyArgumentByVal in FTL
https://bugs.webkit.org/show_bug.cgi?id=128850

Attachment 224439: Added GetMyArgumentByVal to FTL
https://bugs.webkit.org/attachment.cgi?id=224439&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224439&action=review


> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:2052
> +	   speculate(Uncountable, noValue(), 0, m_out.isNull(argsPtr.value()));


You're null-checking the address of the stack offset?  Sounds broken. ;-)