[webkit-reviews] review granted: [Bug 128625] Add fast mapping from StringImpl to JSString : [Attachment 224417] Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 17 15:02:23 PST 2014
Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 128625: Add fast mapping from StringImpl to JSString
https://bugs.webkit.org/show_bug.cgi?id=128625
Attachment 224417: Fix
https://bugs.webkit.org/attachment.cgi?id=224417&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224417&action=review
r=me
> Source/JavaScriptCore/runtime/VM.h:227
> + WeakHandleOwner* jsStringWeakOwner;
This should be OwnPtr, even though we currently only use this for the leaked
VM, to avoid too many cross-cutting memory management assumptions.
More information about the webkit-reviews
mailing list