[webkit-reviews] review granted: [Bug 128914] [CSS Regions] Move specific named flow methods from RenderRegion to RenderNamedFlowFragment : [Attachment 224423] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Feb 17 14:25:53 PST 2014
Antti Koivisto <koivisto at iki.fi> has granted Radu Stavila <stavila at adobe.com>'s
request for review:
Bug 128914: [CSS Regions] Move specific named flow methods from RenderRegion to
RenderNamedFlowFragment
https://bugs.webkit.org/show_bug.cgi?id=128914
Attachment 224423: Patch
https://bugs.webkit.org/attachment.cgi?id=224423&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=224423&action=review
r=me
> Source/WebCore/rendering/RenderNamedFlowFragment.cpp:195
> +RenderBlockFlow* RenderNamedFlowFragment::fragmentContainer() const
> +{
> + ASSERT(parent() && parent()->isRenderNamedFlowFragmentContainer());
> + return toRenderBlockFlow(parent());
> +}
Looks like this is never null. Could you return a reference?
Please assert the conditions separately (makes seeing what failed easier).
> Source/WebCore/rendering/RenderNamedFlowFragment.cpp:200
> +RenderLayer* RenderNamedFlowFragment::fragmentContainerLayer() const
> +{
> + return fragmentContainer()->layer();
> +}
Can this be null?
More information about the webkit-reviews
mailing list