[webkit-reviews] review granted: [Bug 128917] Turn the history client into a fancy API::HistoryClient abstract base class : [Attachment 224396] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 128917: Turn the history client into a fancy API::HistoryClient abstract
base class
https://bugs.webkit.org/show_bug.cgi?id=128917

Attachment 224396: Patch
https://bugs.webkit.org/attachment.cgi?id=224396&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224396&action=review


r=me though there's a disgusting amount of asterisks in this code. :|

> Source/WebKit2/UIProcess/WebContext.h:223
> +    API::HistoryClient& historyClient() { return *m_historyClient; }

I'd use this accessor instead of accessing m_historyClient now, since that lets
you use . instead of ->