[webkit-reviews] review granted: [Bug 128892] FTL should support ToPrimitive and the DFG should fold it in a less dumb way : [Attachment 224334] the patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 128892: FTL should support ToPrimitive and the DFG should fold it in a less
dumb way
https://bugs.webkit.org/show_bug.cgi?id=128892

Attachment 224334: the patch
https://bugs.webkit.org/attachment.cgi?id=224334&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224334&action=review


r=me

> Source/JavaScriptCore/ChangeLog:3
> +	   FTL should support ToPrimitive and the DFG should fold it in a less
dumb way

Let's just say "better".

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:-331
> -	       case StoreBarrier:
> -	       case StoreBarrierWithNullCheck: {

What happened to store barrier?