[webkit-reviews] review denied: [Bug 128549] ENABLED(JIT) && !ENABLED(DFG_JIT) breaks the build : [Attachment 224057] Build fix for enabled JIT with disabled DFG_JIT

[bugzilla-daemon at webkit.org]

Csaba Osztrogonác <ossy at webkit.org> has denied Dániel Bátyai
<dbatyai.u-szeged at partner.samsung.com>'s request for review:
Bug 128549: ENABLED(JIT) && !ENABLED(DFG_JIT) breaks the build
https://bugs.webkit.org/show_bug.cgi?id=128549

Attachment 224057: Build fix for enabled JIT with disabled DFG_JIT
https://bugs.webkit.org/attachment.cgi?id=224057&action=review

------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224057&action=review


r-, because it can't be applied now.

> Source/JavaScriptCore/jit/Repatch.cpp:825
> +#if ENABLE(DFG_JIT)
>      MacroAssembler::Jump definitelyNotMarked =
DFG::SpeculativeJIT::genericWriteBarrier(jit, owner, scratch1, scratch2);
> -    MacroAssembler::Call call = storeToWriteBarrierBuffer(jit, owner,
scratch1, scratch2, allocator);
>      definitelyNotMarked.link(&jit);
> +#endif // ENABLE(DFG_JIT)
> +
> +    MacroAssembler::Call call = storeToWriteBarrierBuffer(jit, owner,
scratch1, scratch2, allocator);

Are you sure if this is the proper fix? I don't understand this code, but these
lines looks to me as they can't be separated.