[webkit-reviews] review granted: [Bug 128877] Move document life time management from TreeScope to Document : [Attachment 224312] build fix

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 128877: Move document life time management from TreeScope to Document
https://bugs.webkit.org/show_bug.cgi?id=128877

Attachment 224312: build fix
https://bugs.webkit.org/attachment.cgi?id=224312&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224312&action=review


r=me. This feels like a good step forward.

> Source/WebCore/dom/Document.h:1714
> -    , m_treeScope(document ? document : &TreeScope::noDocumentInstance())
> +    , m_treeScope(document)

Nice!

> Source/WebCore/dom/DocumentOrderedMap.cpp:94
> +    UNUSED_PARAM(treeScope);
>      ASSERT_WITH_SECURITY_IMPLICATION(element.isInTreeScope());
>     
ASSERT_WITH_SECURITY_IMPLICATION(treeScope.rootNode()->containsIncludingShadowD
OM(&element));

Oh, there's no ASSERT_WITH_SECURITY_IMPLICATION_UNUSED so we have to use
UNUSED_PARAM.
Not ideal but whatever.

> Source/WebCore/dom/Node.cpp:306
>      if (hasRareData())
>	   clearRareData();

This is also done by ~ShadowRoot which no longer seems necessary.

> Source/WebCore/dom/TreeScope.h:98
> +    ContainerNode* rootNode() const { return &m_rootNode; }

I suppose we can make this return ContainerNode& later on.