[webkit-reviews] review requested: [Bug 128852] [Mac] All WebKit clients should encrypt WebCrypto keys automatically : [Attachment 224267] with less 10.8 build breakage

[bugzilla-daemon at webkit.org]

mitz at webkit.org <mitz at webkit.org> has asked  for review:
Bug 128852: [Mac] All WebKit clients should encrypt WebCrypto keys
automatically
https://bugs.webkit.org/show_bug.cgi?id=128852

Attachment 224267: with less 10.8 build breakage
https://bugs.webkit.org/attachment.cgi?id=224267&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224267&action=review


> Source/WebCore/crypto/mac/SerializedCryptoKeyWrapMac.mm:60
> +static NSString* masterKeyAccountNameForCurrentApplication()
> +{
> +    return [NSString
stringWithFormat:@"com.apple.WebKit.WebCrypto.master+%@",
[[NSRunningApplication currentApplication] bundleIdentifier]];
> +}

When building for iOS, won’t this cause an unused function warning?

> Source/WebCore/crypto/mac/SerializedCryptoKeyWrapMac.mm:100
> +    status = SecACLSetContents(acl, (CFArrayRef)@[(id)trustedApp.get()],
(CFStringRef)localizedItemName, kSecKeychainPromptRequirePassphase);

Please add spaces inside the @[].