[webkit-reviews] review granted: [Bug 128867] Setting currentTime on HTMLMediaElement with media controller should throw exception : [Attachment 224297] Patch & layout test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 15 08:27:39 PST 2014
Eric Carlson <eric.carlson at apple.com> has granted Piotr Grad
<p.grad at samsung.com>'s request for review:
Bug 128867: Setting currentTime on HTMLMediaElement with media controller
should throw exception
https://bugs.webkit.org/show_bug.cgi?id=128867
Attachment 224297: Patch & layout test
https://bugs.webkit.org/attachment.cgi?id=224297&action=review
------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224297&action=review
> LayoutTests/media/video-controller-currentTime.html:7
> + function start() {
Nit: a function's opening brace should be on a new line.
> LayoutTests/media/video-controller-currentTime.html:13
> + function canPlayThrough() {
Ditto.
> LayoutTests/media/video-controller-currentTime.html:19
> + try {
> + video.currentTime = 3;
> + } catch (e) {
> + consoleWrite(e);
> + endTest();
> + }
You should also test that an INVALID_STATE_ERR exception is thrown, eg.:
testDOMException("video.currentTime = 3", "DOMException.INVALID_STATE_ERR");
More information about the webkit-reviews
mailing list