[webkit-reviews] review granted: [Bug 128848] [Win] Make tests more consistent with Mac platform : [Attachment 224259] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 128848: [Win] Make tests more consistent with Mac platform
https://bugs.webkit.org/show_bug.cgi?id=128848

Attachment 224259: Patch
https://bugs.webkit.org/attachment.cgi?id=224259&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224259&action=review


> Source/WebKit/win/WebPreferences.h:484
> +    virtual HRESULT STDMETHODCALLTYPE screenFontSubstitutionEnabled(BOOL*);
> +    virtual HRESULT STDMETHODCALLTYPE
setScreenFontSubstitutionEnabled(BOOL);

I'm not sure this one has any effect on Windows.

> Source/WebKit/win/WebView.cpp:5058
> +    hr = prefsPrivate->screenFontSubstitutionEnabled(&enabled);
> +    if (FAILED(hr))
> +	   return hr;
> +    settings.setScreenFontSubstitutionEnabled(enabled);

I think this is a no-op.

> Tools/DumpRenderTree/win/DumpRenderTree.cpp:876
> +    preferences->setCSSRegionsEnabled(TRUE);

Does this mean we can enable a bunch of tests?