[webkit-reviews] review granted: [Bug 128840] ASSERT(isValidAllocation(bytes)) when ObjC API creates custom errors : [Attachment 224250] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 14 14:26:29 PST 2014


Joseph Pecoraro <joepeck at webkit.org> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 128840: ASSERT(isValidAllocation(bytes)) when ObjC API creates custom
errors
https://bugs.webkit.org/show_bug.cgi?id=128840

Attachment 224250: Patch
https://bugs.webkit.org/attachment.cgi?id=224250&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224250&action=review


r=me

> Source/JavaScriptCore/API/JSValue.mm:785
>	   *exception = toRef(JSC::createTypeError(toJS(context), "Cannot
convert primitive to NSArray"));

Nit: You could ASCIILiteral(...) the string being passed to createTypeError,
since it is a string literal turning into a WTF::String.

Is the lock needed by the "tryUnwrapObjcObject" call at the top of these
functions?

Otherwise this is identical to the local fix I had.


More information about the webkit-reviews mailing list