[webkit-reviews] review granted: [Bug 128842] Margin tiles are not created for top and left sides when there is a < 1.0 scale factor : [Attachment 224252] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 14 14:20:18 PST 2014
Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 128842: Margin tiles are not created for top and left sides when there is a
< 1.0 scale factor
https://bugs.webkit.org/show_bug.cgi?id=128842
Attachment 224252: Patch
https://bugs.webkit.org/attachment.cgi?id=224252&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224252&action=review
> Source/WebCore/platform/graphics/ca/mac/TileController.mm:474
> + topLeft.setX(floor((float)clampedRect.x() / leftMarginWidth()));
floorf?
> Source/WebCore/platform/graphics/ca/mac/TileController.mm:479
> + topLeft.setY(floor((float)clampedRect.y() / topMarginHeight()));
Ditto.
More information about the webkit-reviews
mailing list