[webkit-reviews] review granted: [Bug 128710] <rdar://problem/15994340> WK2: Cannot scroll to the bottom of the page when the keyboard is on the screen : [Attachment 224032] Patch

[bugzilla-daemon at webkit.org]

Enrica Casucci <enrica at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 128710: <rdar://problem/15994340> WK2: Cannot scroll to the bottom of the
page when the keyboard is on the screen
https://bugs.webkit.org/show_bug.cgi?id=128710

Attachment 224032: Patch
https://bugs.webkit.org/attachment.cgi?id=224032&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224032&action=review


Looks good to me,

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:353
> +    // FIXME: We will also need to adjust the unobscured rect by taking into
account the keyboard rect and the obsucred insets.

typo: obscured

> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:360
> +    if ([_contentView isAssistingNode])

Maybe you should add a comment explaining that this is the way you figure out
that the notification is for this view.

> Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:290
> +    // FIXME: We will also need to adjust the unobscured rect by taking into
account the keyboard rect and the obsucred insets.

Same typo.