[webkit-reviews] review denied: [Bug 123716] SVG rectangle with filter will not render : [Attachment 224112] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 14 11:35:28 PST 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Adenilson Cavalcanti
Silva <savagobr at yahoo.com>'s request for review:
Bug 123716: SVG rectangle with filter will not render
https://bugs.webkit.org/show_bug.cgi?id=123716

Attachment 224112: Patch
https://bugs.webkit.org/attachment.cgi?id=224112&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224112&action=review


> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:41
> +static const float kMaxFilterArea = 8192 * 8192;

You may have to reduce this given the timing out tests.

> Source/WebCore/platform/graphics/filters/FilterEffect.cpp:67
> +float FilterEffect::maxFilterLength()

Would be nice if you renamed the functions too to include "dimension"

> Source/WebCore/platform/graphics/filters/FilterEffect.h:62
> +    static bool isFilterSizeValid(const IntRect&);
> +    static bool isFilterSizeValid(const FloatRect&);

We implicitly convert IntRect -> FloatRect so you don't need both.


More information about the webkit-reviews mailing list