[webkit-reviews] review denied: [Bug 126855] Web Inspector: scope chain details sidebar doesn't update values modified via console : [Attachment 224166] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 14 10:47:35 PST 2014


Joseph Pecoraro <joepeck at webkit.org> has denied Chris J. Shull
<chrisjshull at gmail.com>'s request for review:
Bug 126855: Web Inspector: scope chain details sidebar doesn't update values
modified via console
https://bugs.webkit.org/show_bug.cgi?id=126855

Attachment 224166: Patch
https://bugs.webkit.org/attachment.cgi?id=224166&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
You need to bind.(this) on both evalCallback calls. There is one on
RuntimeManager.js a few lines down (line 75 after your patches). Otherwise,
just typing in the console normally (not paused) will throw an exception right?


More information about the webkit-reviews mailing list