[webkit-reviews] review granted: [Bug 122320] AX: WebKit needs heuristics to differentiate lists used for layout from semantic data lists, similar to the heuristics for layout tables versus data tables. : [Attachment 224140] patch

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 122320: AX: WebKit needs heuristics to differentiate lists used for layout
from semantic data lists, similar to the heuristics for layout tables versus
data tables.
https://bugs.webkit.org/show_bug.cgi?id=122320

Attachment 224140: patch 
https://bugs.webkit.org/attachment.cgi?id=224140&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224140&action=review


The change looks good to me. My only comments/suggestions is to remove the
PLATFORM(MAC) guard and make the tests cross platform, since I believe this is
a change other ports can benefit of as well.

As for the failing tests in the Mac EWS, it seems to me that the problem is
that the test aria-roles.html needs to be changed because the following snippet
does not match the heuristic to determine that something is a list:

  <!--List-->
  <div class="newRole">
    <p>The following should be a list:</p>
    <p><span tabindex="0" role="list" id="ariaList">X</span></p>
    <p>Actual list:</p>
    <ul id="realList">
	<li>Broccoli</li>
	<li>Beets</li>
    </ul>
    <span id="resultList"></span>
    <script>
	validateRole(document.getElementById('ariaList'),
	    document.getElementById('realList'),
	    document.getElementById('resultList'));
    </script>
  </div>

The problem is that <span tabindex="0" role="list" id="ariaList">X</span> is no
longer going to be identified as a list so I'd say either this whole snippet of
code should be removed (it's tested anyway by list-detection.html, and in a
better way) or adapted.

But other than that I think the patch is fine. Setting r+ anyway, but please
consider these comments before landing

> Source/WebCore/accessibility/AccessibilityList.cpp:120
> +#if PLATFORM(MAC)

I think this change could be done as a cross-platform one

> LayoutTests/ChangeLog:9
> +	   * platform/mac/accessibility/list-detection-expected.txt: Added.
> +	   * platform/mac/accessibility/list-detection.html: Added.

This tests could be moved up to LayoutTests/accessibility if the change is made
cross platform