[webkit-reviews] review granted: [Bug 128728] Do not attempt to synchronize attributes when no Simple Selector could match an animatable attribute : [Attachment 224052] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 128728: Do not attempt to synchronize attributes when no Simple Selector
could match an animatable attribute
https://bugs.webkit.org/show_bug.cgi?id=128728

Attachment 224052: Patch
https://bugs.webkit.org/attachment.cgi?id=224052&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224052&action=review


r=me.

This patch makes me wonder: Would it be better to skip special codegen for
reifying the "style" attribute, and just make it drop to C++ slow path? No sane
content will use a [style="foo"] selector anyway.

> Source/WebCore/cssjit/SelectorCompiler.cpp:974
> +    for (unsigned i = 0; i < fragment.attributes.size(); ++i) {

range for!

> Source/WebCore/cssjit/SelectorCompiler.cpp:976
> +	   const CSSSelector* attributeSelector = fragment.attributes[i];
> +	   const QualifiedName& selectorAttributeName =
attributeSelector->attribute();

I wish SelectorFragment's would hand out const CSSSelector& instead.