[webkit-reviews] review granted: [Bug 127770] Refactoring design-mode-spellcheck-off.html to use asynchronous spellchecking : [Attachment 222426] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 127770: Refactoring design-mode-spellcheck-off.html to use asynchronous
spellchecking
https://bugs.webkit.org/show_bug.cgi?id=127770

Attachment 222426: Patch
https://bugs.webkit.org/attachment.cgi?id=222426&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=222426&action=review


> LayoutTests/editing/spelling/design-mode-spellcheck-off.html:4
> +<script src="../editing.js"></script>

Looks like we can just include this inside body like the other script element.

> LayoutTests/editing/spelling/design-mode-spellcheck-off.html:27
> +    if (!window.internals)
> +	   return;
>  

It would be better if we had this check before shouldBecomeDifferent
so that we can test it in the browser as well as DRT/WTR.