[webkit-reviews] review denied: [Bug 126855] Web Inspector: scope chain details sidebar doesn't update values modified via console : [Attachment 224125] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 13 19:19:33 PST 2014


Timothy Hatcher <timothy at apple.com> has denied Chris J. Shull
<chrisjshull at gmail.com>'s request for review:
Bug 126855: Web Inspector: scope chain details sidebar doesn't update values
modified via console
https://bugs.webkit.org/show_bug.cgi?id=126855

Attachment 224125: Patch
https://bugs.webkit.org/attachment.cgi?id=224125&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224125&action=review


Thanks for looking into this!

> Source/WebInspectorUI/UserInterface/JavaScriptLogViewController.js:228
> +	       WebInspector.scopeChainDetailsSidebarPanel.needsRefresh();

This would be better as an event that the sidebar observes. Having this
low-level view class directly call a higher-level class is a layering
violation.

RuntimeManager would be a good place to fire the event that the sidebar
observes.


More information about the webkit-reviews mailing list