[webkit-reviews] review granted: [Bug 128764] The JSContainerConvertor and ObjcContainerConvertor need to protect JSValueRefs : [Attachment 224143] Part 2 of fix.

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 128764: The JSContainerConvertor and ObjcContainerConvertor need to protect
JSValueRefs
https://bugs.webkit.org/show_bug.cgi?id=128764

Attachment 224143: Part 2 of fix.
https://bugs.webkit.org/attachment.cgi?id=224143&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224143&action=review


r=me

> Source/JavaScriptCore/ChangeLog:8
> +	   toJS() is the wrong cast function to used. We need to use
toJSForGC() instead.

to use.

> Source/JavaScriptCore/ChangeLog:9
> +	   Also we need to acquire the JSLock because to protect accessed to
the Strong

...JSLock to prevent concurrent accesses to the Strong handle list.