[webkit-reviews] review granted: [Bug 127324] REGRESSION (r160259?): text-combine glyphs are not rendered : [Attachment 223322] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Yuki Sekiguchi
<yuki.sekiguchi at access-company.com>'s request for review:
Bug 127324: REGRESSION (r160259?): text-combine glyphs are not rendered
https://bugs.webkit.org/show_bug.cgi?id=127324

Attachment 223322: Patch
https://bugs.webkit.org/attachment.cgi?id=223322&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223322&action=review


> Source/WebCore/rendering/RenderCombineText.cpp:54
> +void RenderCombineText::setTextInternal(const String& text, const bool
replace)

No need for const in front of bool.

> Source/WebCore/rendering/RenderCombineText.h:52
> +    virtual void setTextInternal(const String&, const bool repace = false)
override;

Same here. Also, you have a typo "replace" not "repace"

> Source/WebCore/rendering/RenderText.cpp:1027
> +void RenderText::setTextInternal(const String& text, const bool replace)

And here.