[webkit-reviews] review granted: [Bug 128763] IDB: Three tests crash the DatabaseProcess under ~KeyedDecoder : [Attachment 224107] Patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Feb 13 14:39:37 PST 2014
Anders Carlsson <andersca at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 128763: IDB: Three tests crash the DatabaseProcess under ~KeyedDecoder
https://bugs.webkit.org/show_bug.cgi?id=128763
Attachment 224107: Patch v1
https://bugs.webkit.org/attachment.cgi?id=224107&action=review
------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224107&action=review
> Source/WebCore/platform/KeyedCoding.h:154
> + // Even if this array is empty, the empty array still needs to be
recorded.
> + if (begin == end) {
> + beginArray(key);
> + endArray();
> return;
> + }
Just remove this instead, the code below will do the right thing.
More information about the webkit-reviews
mailing list