[webkit-reviews] review requested: [Bug 127757] Web Inspector: CRASH when debugger closes while paused and remote inspecting a JSContext : [Attachment 224109] [PATCH] Proposed Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 13 14:20:17 PST 2014


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 127757: Web Inspector: CRASH when debugger closes while paused and remote
inspecting a JSContext
https://bugs.webkit.org/show_bug.cgi?id=127757

Attachment 224109: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=224109&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
This addresses 2 known crashes:

    1. Crash when RWI paused and closing RWI
    2. Crash when RWI connected and JSGlobalObject is destroyed

This does mean that each JSGlobalObject allocated an InspectorController /
Inspector{,Runtime,Debugger,Console} agent. But they do nothing unless you open
an RWI connection to the inspector. Soon I will take advantage of the agents
being available outside of a remote debug session and stash exception info.


More information about the webkit-reviews mailing list