[webkit-reviews] review granted: [Bug 128334] Web Inspector: animate breakpoint tree elements when probe samples are received : [Attachment 224097] sync probe set lifetime and listeners to attach/detach.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 128334: Web Inspector: animate breakpoint tree elements when probe samples
are received
https://bugs.webkit.org/show_bug.cgi?id=128334

Attachment 224097: sync probe set lifetime and listeners to attach/detach.
https://bugs.webkit.org/attachment.cgi?id=224097&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224097&action=review


> Source/WebInspectorUI/UserInterface/BreakpointTreeElement.js:121
> +	   for (var probeSet of WebInspector.probeManager.probeSets)
> +	       if (probeSet.breakpoint === this._breakpoint)
> +		   this._addProbeSet(probeSet);

This should return early to prevent walking the whole probe set array once the
right one is found. Returning early also ensures _addProbeSet and
_removeProbeSet are balanced.