[webkit-reviews] review denied: [Bug 128731] There is no rate change event when user agent modifies playback rate. : [Attachment 224056] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has denied Piotr Grad <p.grad at samsung.com>'s
request for review:
Bug 128731: There is no rate change event when user agent modifies playback
rate.
https://bugs.webkit.org/show_bug.cgi?id=128731

Attachment 224056: Patch
https://bugs.webkit.org/attachment.cgi?id=224056&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224056&action=review


> Source/WebCore/platform/graphics/MediaPlayer.cpp:1097
> +    if (!std::isnan(m_private->rate()))

This...

> Source/WebCore/platform/graphics/MediaPlayerPrivate.h:90
> +    virtual float rate() const { return
std::numeric_limits<float>::infinity(); }

Does not match this. So for every platform which does not yet implement this
method, rateChanged() notifications will result in the "rate" being set to
infinity.

Additionally, this means that in the event of a buffer underrun, the video
element will fire a ratechanged event in addition to a stalled event.  I do not
believe this is correct.

Perhaps you could add more information about what problem you are attempting to
solve, and we could come up with a better solution?