[webkit-reviews] review granted: [Bug 128714] Pass the related page in the WebPageConfiguration struct : [Attachment 224038] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 12 19:43:52 PST 2014


Darin Adler <darin at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 128714: Pass the related page in the WebPageConfiguration struct
https://bugs.webkit.org/show_bug.cgi?id=128714

Attachment 224038: Patch
https://bugs.webkit.org/attachment.cgi?id=224038&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224038&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:134
>      WebKit::WebPageConfiguration webPageConfiguration;
>      webPageConfiguration.preferences = [_configuration
preferences]->_preferences.get();
>  

Need to remove these lines of code to make this compile on Mac.


More information about the webkit-reviews mailing list