[webkit-reviews] review denied: [Bug 115643] Document should be constructable : [Attachment 223958] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied László Langó
<llango.u-szeged at partner.samsung.com>'s request for review:
Bug 115643: Document should be constructable
https://bugs.webkit.org/show_bug.cgi?id=115643

Attachment 223958: Patch
https://bugs.webkit.org/attachment.cgi?id=223958&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223958&action=review


Does the test fail if you remove the line of code that says setSecurityOrigin?

> Source/WebCore/dom/Document.cpp:565
> +    document->setSecurityOrigin(adoptRef(context.securityOrigin()));

The adoptRef here is incorrect. This will result in a reference count
underflow.