[webkit-reviews] review granted: [Bug 125433] Hoist and combine array bounds checks : [Attachment 224020] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 125433: Hoist and combine array bounds checks
https://bugs.webkit.org/show_bug.cgi?id=125433

Attachment 224020: the patch
https://bugs.webkit.org/attachment.cgi?id=224020&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224020&action=review


r=me

> Source/JavaScriptCore/dfg/DFGAbstractValue.cpp:77
>	   m_futurePossibleStructure.clear();
>	   m_arrayModes = 0;
>      }
> -	   
> +    
>      m_type = speculationFromValue(value);
>      if (m_type == SpecInt52AsDouble)
>	   m_type = SpecInt52;
>      m_value = value;
> -	   
> +    
>      checkConsistency();
>  }
>  

Revert.

> Source/JavaScriptCore/dfg/DFGInsertionSet.h:62
>      {
>	   return insert(Insertion(index, element));
>      }
> -
> +    
>  #define DFG_DEFINE_INSERT_NODE(templatePre, templatePost, typeParams,
valueParamsComma, valueParams, valueArgs) \
>      templatePre typeParams templatePost Node* insertNode(size_t index,
SpeculatedType type valueParamsComma valueParams) \
>      { \

Revert.