[webkit-reviews] review granted: [Bug 128688] During a copy, position:fixed gets converted to position:absolute even if only part of the document is selected : [Attachment 224005] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted  review:
Bug 128688: During a copy, position:fixed gets converted to position:absolute
even if only part of the document is selected
https://bugs.webkit.org/show_bug.cgi?id=128688

Attachment 224005: Patch
https://bugs.webkit.org/attachment.cgi?id=224005&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224005&action=review


>> Source/WebCore/editing/markup.cpp:328
>>		    m_needRelativeStyleWrapper |=
newInlineStyle->convertFixedAndStickyPosition();
> 
> This is actually broken because convertFixedAndStickyPosition doesn't adjust
coordinates with respect to the wrapping div's. r-.

Oh oops, I completely misunderstood this patch :(

I think we should check settings in createMarkupInternal though.

> Source/WebCore/editing/markup.cpp:570
> +    bool needsPositionStyleConversion = body && fullySelectedRoot == body;

We don't need this separate boolean because fullySelectedRoot can only ever set
to body.

>> Source/WebCore/editing/markup.cpp:627
>> +	if (accumulator.needRelativeStyleWrapper() &&
needsPositionStyleConversion) {
> 
> I don't think we should do this. This would result in another round of
Apple-style-span nightmare.

Ignore this comment.