[webkit-reviews] review granted: [Bug 128687] Web Inspector: Get InspectorIndexedDBAgent working : [Attachment 224010] Patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Timothy Hatcher
<timothy at apple.com>'s request for review:
Bug 128687: Web Inspector: Get InspectorIndexedDBAgent working
https://bugs.webkit.org/show_bug.cgi?id=128687

Attachment 224010: Patch
https://bugs.webkit.org/attachment.cgi?id=224010&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=224010&action=review


> Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:62
> +typedef HashMap<String, HashSet<String>> IDBRecentDatabaseNameMap;
> +
> +static IDBRecentDatabaseNameMap& sharedRecentDatabaseNameMap()

There's been a recent growing backlash against typedefs for maps like these.  I
know there's some in the IDB code already.  Please don't add this new one  :)

> Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:129
> +    ASSERT(!securityOriginIdentifier.isNull());

s/isNull/isEmpty/