[webkit-reviews] review granted: [Bug 127694] Upstream iOS old-run-webkit-tests for use with DumpRenderTree in the iOS Simulator : [Attachment 223972] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted David Farler
<dfarler at apple.com>'s request for review:
Bug 127694: Upstream iOS old-run-webkit-tests for use with DumpRenderTree in
the iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=127694

Attachment 223972: Patch
https://bugs.webkit.org/attachment.cgi?id=223972&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223972&action=review


> Tools/Scripts/old-run-webkit-tests:140
> +my $expectedResultsDir = '';  # PLATFORM_IOS

Can the variable have iOS in to remove the need for the comment?

> Tools/Scripts/old-run-webkit-tests:227
> +my $haveInstalledDumpRenderTreeAppOnce; # PLATFORM_IOS

Ditto.