[webkit-reviews] review denied: [Bug 128688] During a copy, position:fixed gets converted to position:absolute even if only part of the document is selected : [Attachment 224005] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 128688: During a copy, position:fixed gets converted to position:absolute
even if only part of the document is selected
https://bugs.webkit.org/show_bug.cgi?id=128688

Attachment 224005: Patch
https://bugs.webkit.org/attachment.cgi?id=224005&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=224005&action=review


> Source/WebCore/editing/markup.cpp:328
> +	       if (m_needsPositionStyleConversion &&
element.document().settings() &&
element.document().settings()->shouldConvertPositionStyleOnCopy())
>		   m_needRelativeStyleWrapper |=
newInlineStyle->convertFixedAndStickyPosition();

This is actually broken because convertFixedAndStickyPosition doesn't adjust
coordinates with respect to the wrapping div's. r-.