[webkit-reviews] review granted: [Bug 128639] [WK2][iOS] Add back the special viewport for the old xhtml mobile doctype : [Attachment 223921] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 128639: [WK2][iOS] Add back the special viewport for the old xhtml mobile
doctype
https://bugs.webkit.org/show_bug.cgi?id=128639

Attachment 223921: Patch
https://bugs.webkit.org/attachment.cgi?id=223921&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223921&action=review


r=me, thanks for fixing this! (I was the one who removed the doctype stuff..)

> Source/WebCore/dom/Document.cpp:801
> +    page()->chrome().didReceiveDocType(frame());

Since this code doesn't actually check that a doctype tag is present, maybe we
should have a comment about why.
It's also not obvious why this is restricted to PLATFORM(IOS).

> Source/WebCore/page/Chrome.cpp:609
> +    if (DocumentType* documentType = frame->document()->doctype())

I'd harmfully consider auto* here.