[webkit-reviews] review granted: [Bug 128579] Support ANGLE_instanced_arrays for GLES backend. : [Attachment 223956] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted ChangSeok Oh
<changseok.oh at collabora.com>'s request for review:
Bug 128579: Support ANGLE_instanced_arrays for GLES backend.
https://bugs.webkit.org/show_bug.cgi?id=128579

Attachment 223956: Patch
https://bugs.webkit.org/attachment.cgi?id=223956&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223956&action=review


> Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLES.cpp:244
> +    if (m_glDrawArraysInstancedANGLE) {
> +	   m_context->makeContextCurrent();
> +	   m_glDrawArraysInstancedANGLE(mode, first, count, primcount);
> +	   return;
> +    }
> +
> +    m_context->synthesizeGLError(GL_INVALID_OPERATION);

I think this should be the other way around.

if (!m_glDrawArraysInstancedANGLE) {
  m_context->error..
  return;
}

m_context->makeContextCurrent...

e.g. early exit if error, otherwise do the real work.

Same goes for the other two methods here.