[webkit-reviews] review granted: [Bug 128603] [EFL][WK2] Buildfix after bug128569 : [Attachment 223962] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 12 07:47:41 PST 2014


Anders Carlsson <andersca at apple.com> has granted Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 128603: [EFL][WK2] Buildfix after bug128569
https://bugs.webkit.org/show_bug.cgi?id=128603

Attachment 223962: Patch
https://bugs.webkit.org/attachment.cgi?id=223962&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223962&action=review


The patch in bug 128569 was rolled out, so this won't be needed until it's
re-landed.

> Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp:124
> +static unsigned nextWordOffset(const StringView& stringView, unsigned
currentOffset)

StringView should always be passed by value since it's such a small struct that
it fits in two register.


More information about the webkit-reviews mailing list