[webkit-reviews] review granted: [Bug 128185] (try)append and insert operations don't need new operator for PODs : [Attachment 223837] Version with VectorCopier usage

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Wojciech Bielawski
<w.bielawski at samsung.com>'s request for review:
Bug 128185: (try)append and insert operations don't need new operator for PODs
https://bugs.webkit.org/show_bug.cgi?id=128185

Attachment 223837: Version with VectorCopier usage
https://bugs.webkit.org/attachment.cgi?id=223837&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=223837&action=review


> Source/WTF/wtf/Vector.h:161
> +    template<typename U>
> +    static void uninitializedCopy(const T* src, const T* srcEnd, U* dst)
> +    {
> +	   VectorCopier<false, T>::uninitializedCopy(src, srcEnd, dst);
> +    }

Maybe instead we should make VectorCopier<true, T> derive from
VectorCopier<false, T>?