[webkit-reviews] review granted: [Bug 128614] [New Multicolumn] getClientRects returns wrong rectangle : [Attachment 223893] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Feb 11 13:30:41 PST 2014


Sam Weinig <sam at webkit.org> has granted Dave Hyatt <hyatt at apple.com>'s request
for review:
Bug 128614: [New Multicolumn] getClientRects returns wrong rectangle
https://bugs.webkit.org/show_bug.cgi?id=128614

Attachment 223893: Patch
https://bugs.webkit.org/attachment.cgi?id=223893&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=223893&action=review


> Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:180
> +	   return 0;

We have been switching to nullptr in cases like this.

> Source/WebCore/rendering/RenderMultiColumnFlowThread.cpp:192
> +	   return 0;

We have been switching to nullptr in cases like this.


More information about the webkit-reviews mailing list